sequential: use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+#216
Conversation
# golang.org/x/sys/windows
Error: C:\Users\runneradmin\go\pkg\mod\golang.org\x\sys@v0.37.0\windows\security_windows.go:1318:39: undefined: unsafe.SliceData
Error: C:\Users\runneradmin\go\pkg\mod\golang.org\x\sys@v0.37.0\windows\security_windows.go:1321:39: undefined: unsafe.SliceData
Error: C:\Users\runneradmin\go\pkg\mod\golang.org\x\sys@v0.37.0\windows\security_windows.go:1324:40: undefined: unsafe.SliceData
Error: C:\Users\runneradmin\go\pkg\mod\golang.org\x\sys@v0.37.0\windows\security_windows.go:1327:40: undefined: unsafe.SliceDataLooks like we need to bump the module to go1.20 as minimum; 
|
|
Oh! Probably the other module that is ( |
694e9c8 to
a8ce7d7
Compare
I had already bumped to 1.24 (via x/sys update that had this as minimum). This is the 1.18 hacks. I removed my previous attempt to patch the 1.18 workarounds and removed it from CI like I initially did in #214 . I've already spent way too much time on these 1.18 exceptions that nobody needs. |
We should remove the required checks in branch protection. Makes little sense to keep them anyway. |
a8ce7d7 to
7208400
Compare
Go 1.26 adds support for passing Windows file flags via os.OpenFile, eliminating the need to call windows.CreateFile directly. Split the implementation into build-tagged files: go1.26+ uses os.OpenFile with the new O_FILE_FLAG_SEQUENTIAL_SCAN open flag, while older versions retain the manual CreateFile approach. Also bump golang.org/x/sys to v0.37.0 (provides the new constant) and update the minimum Go version to 1.24. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7208400 to
9d2fc63
Compare
| ) | ||
|
|
||
| func openFileSequential(name string, flag int, perm os.FileMode) (*os.File, error) { | ||
| return os.OpenFile(name, flag|windows.O_FILE_FLAG_SEQUENTIAL_SCAN, perm) |
There was a problem hiding this comment.
once we drop support for < go1.26, we should define this as a local const, so that we no longer have a dependency on "golang.org/x/sys/windows"
Go 1.26 adds support for passing Windows file flags via os.OpenFile, eliminating the need to call windows.CreateFile directly. Split the implementation into build-tagged files: go1.26+ uses os.OpenFile with the new O_FILE_FLAG_SEQUENTIAL_SCAN open flag, while older versions retain the manual CreateFile approach.
Also bump golang.org/x/sys to v0.37.0 (provides the new constant) and update the minimum Go version to 1.24.
https://go-review.googlesource.com/c/go/+/699415
https://go-review.googlesource.com/c/go/+/724621